Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-24903] Aborts long running regular expressions #23

Merged
merged 2 commits into from Dec 6, 2015

Conversation

Projects
None yet
1 participant
@ikedam
Copy link
Member

ikedam commented Nov 22, 2015

JENKINS-24903

Some regular expressions can cause catastrophic backtracking.
Malicious users can configure those regular expressions in naginator plugin and and harm Jenkins.

This request adds a feature to aborts regular expressions running too long time.

@ikedam

This comment has been minimized.

Copy link
Member Author

ikedam commented Nov 22, 2015

Added a test to reproduce the problem.
That regular expression causes too long execution time.

[FIXED JENKINS-24903] Aborts too long running regular expressions. Ad…
…ded a configuration field for the timeout.
@ikedam

This comment has been minimized.

Copy link
Member Author

ikedam commented Nov 22, 2015

Introduced a new configuration field in the system configuration page:
regexptimeoutms

ikedam added a commit that referenced this pull request Dec 6, 2015

Merge pull request #23 from ikedam/feature/JENKINS-24903_InfiniteRegu…
…larExpression

[JENKINS-24903] Aborts long running regular expressions

@ikedam ikedam merged commit d86ff5b into jenkinsci:master Dec 6, 2015

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.