Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-43803] Fix wrong calcuration of `ProgressiveDelay` when 2 series of retries run alternately. #46

Merged
merged 2 commits into from Feb 23, 2019

Conversation

Projects
None yet
1 participant
@ikedam
Copy link
Member

ikedam commented Feb 10, 2019

https://issues.jenkins-ci.org/browse/JENKINS-43803
ProgressiveDelay uses getPrevisousBuild() to calculate next retrying numbers.
It results wrong calcurations like:

Build Correct next retrying number number by ProgressiveDelay
BuildA (initial) 1 1
BuildA (1st retry) 2 2
BuildB (initial) 1 1
BuildA (2nd retry) 3 2

This happens as ProgressiveDelay takes BuildB as the last build of "BuildA (2nd retry)".

[JENKINS-43803] Add a test to reproduce JENKINS-43803
* ProgressiveDelay calculates wrong values when 2 series of retries run at the same time.

@ikedam ikedam closed this Feb 10, 2019

@ikedam ikedam reopened this Feb 10, 2019

delay.computeScheduleDelay(buildA2),
delay.computeScheduleDelay(buildA3)
)
);

This comment has been minimized.

@ikedam ikedam changed the title WIP: [JENKINS-43803] Fix wrong calcuration of `ProgressiveDelay` when 2 series of retries run alternately. [JENKINS-43803] Fix wrong calcuration of `ProgressiveDelay` when 2 series of retries run alternately. Feb 10, 2019

@ikedam ikedam merged commit 789d221 into jenkinsci:master Feb 23, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.