Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue JENKINS-18642 (Job build is marked as failed if NUnit test result contains only ignored tests) #6

Merged
merged 1 commit into from Jul 24, 2014

Conversation

@bartensud
Copy link
Contributor

bartensud commented Jul 6, 2013

Hi,
I've made a fix for jenkins issue https://issues.jenkins-ci.org/browse/JENKINS-18642

As this is the first time I'm doing a pull request, I hope I did everything in the right way:)

Best regards
Tom

@buildhive

This comment has been minimized.

Copy link

buildhive commented Jul 6, 2013

Jenkins » nunit-plugin #10 SUCCESS
This pull request looks good
(what's this?)

@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Jul 7, 2013

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@kinow

This comment has been minimized.

Copy link
Member

kinow commented Jul 24, 2014

Hi @bartensud!

Your patch looks good, I'm merging and releasing it. I'll include in the release notes that the behaviour has changed for skipped tests, feel free to chime in and edit the wikipedia if the description is not good enough. And sorry for taking so long to take a look at this.

Cheers, Bruno

kinow added a commit that referenced this pull request Jul 24, 2014
Fix for issue JENKINS-18642 (Job build is marked as failed if NUnit test result contains only ignored tests)
@kinow kinow merged commit b4dce99 into jenkinsci:master Jul 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.