Migrate from Commons HttpClient 3.x to HttpComponents Client 4.x #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #293. The critical change that my previous PRs have been leading up to: stop depending on Commons HttpClient 3.x from core so that HttpClient 3.x can be removed from core. To implement this, there are two options:
commons-httpclient3-api
(Use Commons HttpClient 3.x API plugin #293)apache-httpcomponents-client-4-api
(this PR)This PR is greater risk because it is upgrading the dependency from version 3.x to 4.x. Some testing would be appreciated. The existing unit test had to be deleted, because there is no way to implement it with HttpClient 4.x, which does not expose proxy information from
DefaultHttpClient
.CC @damianszczepanik