Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-49715] Facelift & JEP-200 fix #22

Merged
merged 4 commits into from Mar 7, 2018

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Member

commented Feb 26, 2018

#21 + JENKINS-49715 (these actually cover distinct though related errors).

  • facelift
  • reproduce & fix XStream error
  • reproduce & fix Remoting error

@reviewbybees esp. @oleg-nenashev

jglick added some commits Feb 26, 2018

Fixing getExecutable problem by avoiding anonymous inner class callab…
…les that pick up unrelated instance fields.
Removing gratuitous templateModeJsonObj from serial form.
This was just an artifact of the nonstandard @DataBoundConstructor and duplicated fields which were already stored.

@jglick jglick changed the title [WiP] [JENKINS-49715] Facelift & JEP-200 fix [JENKINS-49715] Facelift & JEP-200 fix Feb 26, 2018

@oleg-nenashev
Copy link
Member

left a comment

LGTM. AFAICT it does not cause data loss, right?

</plugin>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Feb 26, 2018

Member

Not sure about Jacoco removal. These settings differ from what the Plugin POM has

This comment has been minimized.

Copy link
@jglick

jglick Feb 27, 2018

Author Member

Yeah but I figured that POM section is so old that if JaCoCo is still needed, it would be better to reëvaluate the parent default settings and make any necessary adjustments.

@jglick

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2018

it does not cause data loss, right?

Not that I know of—the problematic field simply repeated information already present in other fields.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

@jglick

This comment has been minimized.

Copy link
Member Author

commented Feb 28, 2018

@jdamick ping

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Mar 7, 2018

@jdamick ping. Jenkins LTS 2.107.1 lands within 1 week. If the plugin fix is not released by that time, there will be a bigger impact on users.

@jdamick

jdamick approved these changes Mar 7, 2018

@jdamick jdamick merged commit f318a25 into jenkinsci:master Mar 7, 2018

@jglick jglick deleted the jglick:updates-JENKINS-49715 branch Mar 9, 2018

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Mar 14, 2018

@jdamick the fix has not been released yet. Jenkins 2.107.1 will be released today, the plugin in the current state will be broken there

@jdamick

This comment has been minimized.

Copy link
Member

commented Mar 14, 2018

i'm unable to publish the plugin because for some reason in the release-plugin it's failing.. it's not obvious and will require more time than i have atm.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Mar 14, 2018

@jdamick we could help with diagnostics if you provide logs

@jdamick

This comment has been minimized.

Copy link
Member

commented Mar 14, 2018

can someone else publish it or does it have to be me?

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Mar 19, 2018

@jdamick only you have permissions to do it according to https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-packer.yml

If you provide explicit approval in this thread, me or @jglick could release it

@jglick jglick referenced this pull request Mar 19, 2018

Merged

Adding jglick to packer #640

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.