Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-29922] Adding symbols for a smoother step appearance #19

Merged
merged 2 commits into from Jul 29, 2016

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Member

jglick commented Jul 28, 2016

JENKINS-29922

  • update to new parent (incl. FindBugs & -source 7 cleanups)
  • add @Symbol
  • verify usage in tests
  • update demo (needs some plugins released and propagated to UC)

@reviewbybees esp. @abayer, @kohsuke

workflow-scm-step:1.13
workflow-step-api:1.13
workflow-support:1.13
workflow-api:2.0

This comment has been minimized.

Copy link
@jglick

jglick Jul 28, 2016

Author Member

Versions are approximate, will need to be refined.

This comment has been minimized.

Copy link
@abayer

abayer Jul 28, 2016

Member

Ah, the downside of no longer having one version across the whole suite...

<div>
Asks Jenkins to analyze the timing of tests from the last build and divide the tests for this build into roughly equal subsets for <code>parallel</code> execution.
<a href="https://github.com/jenkinsci/parallel-test-executor-plugin/blob/master/demo/repo/Jenkinsfile" target="_blank">example <code>Jenkinsfile</code></a>
</div>

This comment has been minimized.

Copy link
@jglick

jglick Jul 28, 2016

Author Member

Unrelated, but forgotten before.

jglick added a commit to jglick/workflow-cps-plugin that referenced this pull request Jul 28, 2016

@@ -22,6 +23,7 @@ public int calculate(List<TestClass> tests) {
return size;
}

@Symbol("count")

This comment has been minimized.

Copy link
@abayer

abayer Jul 28, 2016

Member

Question that just popped to mind - are the @Symbols scoped by anything? Or if we use count as the symbol here, does that mean nothing else can use count anywhere else? Worrying that we may need some kind of @Symbol registry for tracking the things...

This comment has been minimized.

Copy link
@jglick

jglick Jul 28, 2016

Author Member

Yes they are scoped by extension point. See Javadoc.

This comment has been minimized.

Copy link
@abayer

abayer Jul 28, 2016

Member

That is an immense relief. =)

if (workspace == null) {
throw new AbortException("no workspace");
}
int k = workspace.copyRecursiveTo(parameterBinding.filePattern, target);

This comment has been minimized.

Copy link
@abayer

abayer Jul 28, 2016

Member

🐜 Inconsistent indentation?

This comment has been minimized.

Copy link
@jglick

jglick Jul 28, 2016

Author Member

Was already like that, just trying to minimize the diff hunk.

This comment has been minimized.

Copy link
@abayer

abayer Jul 28, 2016

Member

No worries - just checking.

@abayer

This comment has been minimized.

Copy link
Member

abayer commented Jul 28, 2016

🐝 as is, but I assume there's more commits on the way for the demo.

@abayer

This comment has been minimized.

Copy link
Member

abayer commented Jul 28, 2016

re-🐝

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jul 28, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick jglick merged commit 1e78103 into jenkinsci:master Jul 29, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:symbol-JENKINS-29922 branch Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.