Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-22856] Uses AbstractProject instead of Item in Descriptor.doCheckProjects #68

Conversation

Projects
None yet
3 participants
@ikedam
Copy link
Member

commented May 19, 2014

JENKINS-22856

It can be get confused with JobPropertyImpl.getJobOverrides or /lib/form/withCustomDescriptorByName, that is, Cloudbees Template plugin.

See following for more details:
https://groups.google.com/forum/#!topic/jenkinsci-dev/wOUBUlnE24Y

[FIXED JENKINS-22856] Uses AbstractProject instead of Item in Descrip…
…tor.doCheckProjects. It can be get confused with JobPropertyImpl.getJobOverrides or /lib/form/withCustomDescriptorByName.
@ikedam

This comment has been minimized.

Copy link
Member Author

commented May 19, 2014

As many methods in BuildTriggerConfig is designed to work with AbstractProject, I think there would be no regression by switching Item to AbstractProject.

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented May 19, 2014

plugins » parameterized-trigger-plugin #83 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented May 20, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

ikedam added a commit that referenced this pull request May 31, 2014

Merge pull request #68 from ikedam/feature/JENKINS-22856_AncestorForD…
…oCheckProjects

[JENKINS-22856] Uses AbstractProject instead of Item in Descriptor.doCheckProjects

@ikedam ikedam merged commit ea8b3df into jenkinsci:master May 31, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.