Skip to content

Support waitForCompletion in cfInvalidate#119

Merged
hoegertn merged 1 commit into
jenkinsci:masterfrom
brainbeanapps:cfInvalidate-completion
Aug 12, 2018
Merged

Support waitForCompletion in cfInvalidate#119
hoegertn merged 1 commit into
jenkinsci:masterfrom
brainbeanapps:cfInvalidate-completion

Conversation

@alexey-pelykh
Copy link
Copy Markdown
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message describes your change
  • Tests for the changes have been added if possible (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Changes are mentioned in the changelog (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Minor feature of waitForCompletion in cfInvalidate

  • What is the current behavior? (You can also link to an open issue here)

Currently invalidation is only enqueued and current log is misleading

  • What is the new behavior (if this is a feature change)?

It's a non-breaking-change, by default behaviour is the same, but log message is modified.

  • Does this PR introduce a breaking change? (What changes might users need to make in their setup due to this PR?)

No

  • Other information:

N/A

@hoegertn
Copy link
Copy Markdown
Contributor

Great idea, but please use client.waiters().invalidationCompleted().run(...);

@alexey-pelykh alexey-pelykh force-pushed the cfInvalidate-completion branch from ad87409 to b4de252 Compare August 12, 2018 16:35
@alexey-pelykh
Copy link
Copy Markdown
Contributor Author

Done

@hoegertn hoegertn merged commit 1c9d45f into jenkinsci:master Aug 12, 2018
@alexey-pelykh alexey-pelykh deleted the cfInvalidate-completion branch August 12, 2018 17:13
@rkul
Copy link
Copy Markdown

rkul commented Aug 30, 2018

Could you tell me when this amazing feature will be released?

@hoegertn
Copy link
Copy Markdown
Contributor

I will try to build a release by the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants