Skip to content

ecrLogin: support setting registry ids explicitly#217

Merged
hoegertn merged 1 commit intojenkinsci:masterfrom
brainbeanapps:ecrLogin-registryIds
Feb 26, 2020
Merged

ecrLogin: support setting registry ids explicitly#217
hoegertn merged 1 commit intojenkinsci:masterfrom
brainbeanapps:ecrLogin-registryIds

Conversation

@alexey-pelykh
Copy link
Copy Markdown
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message describes your change
  • Tests for the changes have been added if possible (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Changes are mentioned in the changelog (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Support of non-default AWS account for ECR login

  • What is the current behavior? (You can also link to an open issue here)

ECR login is performed into default AWS account

  • What is the new behavior (if this is a feature change)?

ECR login is performed into specified AWS account, or default one if not specified

  • Does this PR introduce a breaking change? (What changes might users need to make in their setup due to this PR?)

No

  • Other information:

Copy link
Copy Markdown
Contributor

@hoegertn hoegertn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Can you please adjust the documentation and add the feature to the changelog.

@alexey-pelykh alexey-pelykh force-pushed the ecrLogin-registryIds branch 2 times, most recently from dba80b6 to 7fb56f7 Compare February 26, 2020 01:40
@alexey-pelykh
Copy link
Copy Markdown
Contributor Author

@hoegertn I hope I did that right :)

@hoegertn
Copy link
Copy Markdown
Contributor

Please rebase on master. The Update branch button does not work for me.

@alexey-pelykh
Copy link
Copy Markdown
Contributor Author

Done 👍

@hoegertn hoegertn merged commit 4285121 into jenkinsci:master Feb 26, 2020
@alexey-pelykh alexey-pelykh deleted the ecrLogin-registryIds branch February 26, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants