ecrLogin: support setting registry ids explicitly#217
Merged
hoegertn merged 1 commit intojenkinsci:masterfrom Feb 26, 2020
Merged
ecrLogin: support setting registry ids explicitly#217hoegertn merged 1 commit intojenkinsci:masterfrom
hoegertn merged 1 commit intojenkinsci:masterfrom
Conversation
c422f60 to
c4ca826
Compare
hoegertn
requested changes
Feb 25, 2020
Contributor
hoegertn
left a comment
There was a problem hiding this comment.
Thanks for the change. Can you please adjust the documentation and add the feature to the changelog.
dba80b6 to
7fb56f7
Compare
Contributor
Author
|
@hoegertn I hope I did that right :) |
Contributor
|
Please rebase on master. The Update branch button does not work for me. |
hoegertn
approved these changes
Feb 26, 2020
7fb56f7 to
d118338
Compare
Contributor
Author
|
Done 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support of non-default AWS account for ECR login
ECR login is performed into default AWS account
ECR login is performed into specified AWS account, or default one if not specified
No