New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for hanging `build` steps #9

Merged
merged 5 commits into from Nov 21, 2016

Conversation

Projects
None yet
4 participants
@jglick
Member

jglick commented Nov 1, 2016

  • found a somewhat artificial case where interrupting a build would not break you out of a loop
  • make sure interrupt does something
  • work around core bug JENKINS-39454

@reviewbybees

If BuildTriggerStepExecution.stop is called, make sure the step is no…
…t marked as having completed successfully, even if propagate: false.
@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Nov 1, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

reviewbybees commented Nov 1, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

jglick added some commits Nov 2, 2016

If BuildTriggerStepExecution.stop did not actually do anything else, …
…pass on the interrupt to onFailure.

Should help with (currently unreproducible) situations where we are "unsure what happened to downstream build".
@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Nov 6, 2016

Member

Can probably try working around JENKINS-39454 prior to jenkinsci/jenkins#2609 by adjusting the action to hold a list of structs.

Member

jglick commented Nov 6, 2016

Can probably try working around JENKINS-39454 prior to jenkinsci/jenkins#2609 by adjusting the action to hold a list of structs.

@jglick jglick changed the title from Better honor BuildTriggerStepExecution.stop to Various fixes for hanging `build` steps Nov 7, 2016

@abayer

This comment has been minimized.

Show comment
Hide comment
@abayer

abayer Nov 21, 2016

Member

🐝

Member

abayer commented Nov 21, 2016

🐝

@jglick jglick merged commit 5c357d7 into jenkinsci:master Nov 21, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:interruptFlowNonPropagate branch Nov 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment