Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-39134] Work around Guice problem #11

Merged

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

commented Nov 29, 2016

JENKINS-39134

Fixes the symptom, pending some understanding of the root problem.

@reviewbybees

@jglick jglick closed this Nov 29, 2016

@jglick jglick reopened this Nov 29, 2016

@reviewbybees

This comment has been minimized.

Copy link

commented Nov 29, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer

abayer approved these changes Nov 30, 2016

Copy link
Member

left a comment

🐝

@alvarolobato

This comment has been minimized.

Copy link
Member

commented Nov 30, 2016

🐝

Thanks for the fix @jglick

@jglick

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2016

@jglick

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2016

Note that I left a comment to the effect that the code could be further simplified by getting rid of the formerly injected fields and replacing references by calls to getContext.get(Type.class), but I preferred to stick with a more conservative diff to get the fix out there.

@alvarolobato alvarolobato merged commit 0fbb0d2 into jenkinsci:master Dec 1, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:CreationException-JENKINS-39134 branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.