Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-43339] Properly set result from FlowInterruptedException #153

Merged
merged 4 commits into from Apr 25, 2017

Conversation

Projects
None yet
3 participants
@abayer
Copy link
Member

commented Apr 21, 2017

  • JENKINS issue(s):
  • Description:
    • We should be setting the build result to FlowInterruptedException.getResult() when we catch a FlowInterruptedException, since there's actually a relevant result there. Also added a notBuilt post status while I was here.
  • Documentation changes:
    • n/a
  • Users/aliases to notify:
[FIXED JENKINS-43339] Properly set result from FlowInterruptedException
We should be setting the build result to
FlowInterruptedException.getResult() when we catch a
FlowInterruptedException, since there's actually a relevant result
there. Also added a notBuilt post status while I was here.

@abayer abayer added this to the 1.1.4 milestone Apr 21, 2017

@abayer abayer requested a review from rsandell Apr 21, 2017

@reviewbybees

This comment has been minimized.

Copy link

commented Apr 21, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@rsandell
Copy link
Member

left a comment

🐝


j.waitForCompletion(run2);

j.assertBuildStatus(Result.NOT_BUILT, j.waitForCompletion(run1));

This comment has been minimized.

Copy link
@rsandell

rsandell Apr 25, 2017

Member

Might be prudent to check that run2 was successful as well.

This comment has been minimized.

Copy link
@abayer

abayer Apr 25, 2017

Author Member

Whoops!


j.assertBuildStatus(Result.NOT_BUILT, j.waitForCompletion(run1));

j.assertLogContains("Job not built due to milestone", run1);

This comment has been minimized.

Copy link
@rsandell

rsandell Apr 25, 2017

Member

Might be prudent to check that run2 does not contain this text.

abayer added some commits Apr 25, 2017

@rsandell
Copy link
Member

left a comment

🐝

@abayer abayer merged commit a443e04 into jenkinsci:master Apr 25, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.