Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-45081] Don't error out for foo.pipeline { ... } #166

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
3 participants
@abayer
Copy link
Member

abayer commented Jul 6, 2017

  • JENKINS issue(s):
  • Description:
    • We were erroring out if you had a Scripted Pipeline with, say, a global variable foo with a method on it named pipeline that was being called like, say, foo.pipeline { echo 'Hi there' }. That...was not right. This fixes that. =)
  • Documentation changes:
    • n/a
  • Users/aliases to notify:

@abayer abayer requested a review from rsandell Jul 6, 2017

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jul 6, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@rsandell
Copy link
Member

rsandell left a comment

🐝 I can't see how this change would have fixed it, but I don't see anything wrong with the change.

@abayer

This comment has been minimized.

Copy link
Member Author

abayer commented Jul 6, 2017

@rsandell It's actually kinda nifty - matchMethodName returns null if the MethodCallExpression's being called on anything other than this!

@abayer abayer merged commit 2c0b4d6 into jenkinsci:master Jul 6, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.