Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-46112] Test demonstrating that error steps get log actions now #180

Merged
merged 5 commits into from Aug 17, 2017

Conversation

Projects
None yet
3 participants
@abayer
Copy link
Member

commented Aug 10, 2017

  • JENKINS issue(s):
  • Description:
    • They didn't in 1.1.9 (and probably earlier) for no reason I can figure out, but they do now. Again, for no reason I can figure out.
  • Documentation changes:
    • n/a
  • Users/aliases to notify:
[JENKINS-46112] Test demonstrating that error steps get log actions now
They didn't in 1.1.9 (and probably earlier) for no reason I can figure
out, but they do now. Again, for no reason I can figure out.

@abayer abayer added this to the 1.2 milestone Aug 10, 2017

@abayer abayer requested a review from rsandell Aug 10, 2017

@reviewbybees

This comment has been minimized.

Copy link

commented Aug 10, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@rsandell
Copy link
Member

left a comment

You seem to have missed adding a file to the commit.

abayer added some commits Aug 11, 2017

Merge remote-tracking branch 'origin/master' into jenkins-46112
Conflicts:
	pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BasicModelDefTest.java
@abayer

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2017

...I swear this passed before. Digging.

@abayer

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2017

Ok, verified that this does pass on top of #174. So this'll wait 'til that's merged.

Merge branch 'master' into jenkins-46112
Conflicts:
	pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BasicModelDefTest.java

@abayer abayer merged commit 83d002b into jenkinsci:master Aug 17, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.