Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-46544] Error on usage of unquoted ${...} #188

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
3 participants
@abayer
Copy link
Member

abayer commented Aug 30, 2017

  • JENKINS issue(s):
  • Description:
    • This isn't something we should allow, so now we check for it and do something about it. The problem isn't specific to the ticket's case of environment, so we're going to error out on any non-literal ModelASTValue that has a toGroovy() value starting with ${.
  • Documentation changes:
    • n/a
  • Users/aliases to notify:
[FIXED JENKINS-46544] Error on usage of unquoted ${...}
This isn't something we should allow, so now we check for it and do
something about it.

@abayer abayer added this to the 1.2 milestone Aug 30, 2017

@abayer abayer requested a review from rsandell Aug 30, 2017

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Aug 30, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@rsandell
Copy link
Member

rsandell left a comment

🐝

@abayer abayer merged commit 413cc1a into jenkinsci:master Sep 6, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.