Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-26148] Using default implementation of StepExecution.stop #191

Merged
merged 2 commits into from Sep 28, 2017

Conversation

@jglick
Copy link
Member

jglick commented Sep 4, 2017

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Sep 4, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

rsandell left a comment

🐝

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Sep 7, 2017

@abayer

This comment has been minimized.

Copy link
Member

abayer commented Sep 20, 2017

@jglick Resolve the merge conflict and I'll merge.

@abayer abayer added this to the 1.2 milestone Sep 20, 2017
@abayer abayer force-pushed the jglick:StepExecution.stop-JENKINS-26148 branch from 183a288 to 4092168 Sep 21, 2017
Conflicts:
	pom.xml
@abayer

This comment has been minimized.

Copy link
Member

abayer commented Sep 21, 2017

Ignore my initial dumb backwards merge commit. Pushed the right merge to your branch, once it passes tests, I'll merge it.

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Sep 25, 2017

@abayer passing.

@abayer abayer modified the milestones: 1.2, 1.2.1 Sep 28, 2017
@abayer
abayer approved these changes Sep 28, 2017
@abayer abayer merged commit 5c2b7d1 into jenkinsci:master Sep 28, 2017
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@jglick jglick deleted the jglick:StepExecution.stop-JENKINS-26148 branch Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.