Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-47202] Switch to HashMaps for env to fix serialization #204

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
4 participants
@abayer
Copy link
Member

abayer commented Oct 4, 2017

  • JENKINS issue(s):
  • Description:
    • TreeMap#Entry isn't serializable, which can bite you in the weirdest places. Like here - if environment variable values end up triggering a program save, tada, you get a NotSerializableException. Which is bad. I can't reproduce this consistently - maybe 3 times out of 4, it'll fail. But this fix has yet to reproduce the error after 20+ attempts, so I think it's good.
  • Documentation changes:
    • n/a
  • Users/aliases to notify:
[FIXED JENKINS-47202] Switch to HashMaps for env to fix serialization
TreeMap#Entry isn't serializable, which can bite you in the weirdest
places. Like here - if `environment` variable values end up triggering
a program save, tada, you get a `NotSerializableException`. Which is
bad. I can't reproduce this consistently - maybe 3 times out of 4,
it'll fail. But this fix has yet to reproduce the error after 20+
attempts, so I think it's good.

@abayer abayer added this to the 1.2.2 milestone Oct 4, 2017

@abayer abayer requested review from rsandell and svanoort Oct 4, 2017

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Oct 4, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@rsandell
Copy link
Member

rsandell left a comment

So there isn't a sure way to make sure the program state gets saved at some place?

Otherwise I believe I've seen some use of @Repeat somewhere.

@abayer

This comment has been minimized.

Copy link
Member Author

abayer commented Oct 4, 2017

So there is via sleep, but there's no logical way to do a sleep in environment...

@abayer abayer merged commit 3aabd8d into jenkinsci:master Oct 4, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.