Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-47421] Make sure we init stagesList in readResolve #207

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
3 participants
@abayer
Copy link
Member

abayer commented Oct 20, 2017

  • JENKINS issue(s):
  • Description:
    • This is a very minor issue in practice - the ExecutionModelAction isn't really used by anything but our own check for multiple executed pipeline blocks, which itself can't ever be the case on builds that started before Declarative 1.2 in the first place. Buuuuut it does result in some weird unreadable data messages in Jenkins, so let's play things very safe.
  • Documentation changes:
    • n/a
  • Users/aliases to notify:
[FIXED JENKINS-47421] Make sure we init stagesList in readResolve
This is a very minor issue in practice - the ExecutionModelAction
isn't really used by anything but our own check for multiple executed
pipeline blocks, which itself can't ever be the case on builds that
started before Declarative 1.2 in the first place. Buuuuut it does
result in some weird unreadable data messages in Jenkins, so let's
play things very safe.

@abayer abayer requested a review from rsandell Oct 20, 2017

@abayer abayer added this to the 1.2.3 milestone Oct 20, 2017

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Oct 20, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer abayer requested a review from svanoort Oct 23, 2017

@rsandell
Copy link
Member

rsandell left a comment

🐝

@abayer abayer merged commit cf1438d into jenkinsci:master Oct 23, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.