Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-47559] Don't do full validation for non-conditions #209

Merged
merged 1 commit into from Oct 23, 2017

Conversation

@abayer
Copy link
Member

abayer commented Oct 23, 2017

  • JENKINS issue(s):
  • Description:
    • This has actually always been a potential problem but nothing in validation until 1.2 actually checked condition names via .equals. That'll end up null if you've got a non-method for the condition, so...tada. This fixes that by skipping the rest of validation in that case (since there's nothing more to validate!) and uses a better error message.
  • Documentation changes:
    • n/a
  • Users/aliases to notify:
@abayer abayer requested review from rsandell and svanoort Oct 23, 2017
@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Oct 23, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

rsandell left a comment

🐝

@abayer abayer merged commit e8a7877 into jenkinsci:master Oct 23, 2017
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.