Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-47780] Fix instantiation time scoping of describables #215

Merged
merged 1 commit into from Nov 8, 2017

Conversation

@abayer
Copy link
Member

abayer commented Nov 6, 2017

  • JENKINS issue(s):
  • Description:
    • Actually fixing JENKINS-47780, because I only tested the validation before. D'oh. Still should probably get this more elegant, with auto-determination of context and valid describable types, but this works for now.
  • Documentation changes:
    • n/a
  • Users/aliases to notify:
@abayer abayer requested review from rsandell, ikedam and svanoort Nov 6, 2017
@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Nov 6, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@ikedam
ikedam approved these changes Nov 6, 2017
Copy link
Member

ikedam left a comment

I verified this change fixes JENKINS-47780.
Thanks!

Copy link
Member

rsandell left a comment

🐝

@abayer abayer merged commit f567261 into jenkinsci:master Nov 8, 2017
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.