Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED JENKINS-52084] Execute sequential stage post in correct context #272

Merged
merged 1 commit into from Jun 27, 2018
Merged

[FIXED JENKINS-52084] Execute sequential stage post in correct context #272

merged 1 commit into from Jun 27, 2018

Conversation

abayer
Copy link
Member

@abayer abayer commented Jun 26, 2018

  • JENKINS issue(s):
  • Description:
    • We were executing post for a sequential stage parent the same way we do for parallel, but given that a sequential stage parent can define environment, agent, tools, etc, we should be running its post within those contexts.
  • Documentation changes:
    • n/a
  • Users/aliases to notify:
    • ...

@abayer
[FIXED JENKINS-52084] Execute sequential stage post in correct context
880bdac 
We were executing post for a sequential stage parent the same way we
do for parallel, but given that a sequential stage parent can define
environment, agent, tools, etc, we should be running its post within
those contexts.
@abayer abayer added this to the 1.3.1 milestone Jun 26, 2018
kshultzCB
kshultzCB approved these changes Jun 26, 2018
View reviewed changes
Copy link
Contributor

@kshultzCB kshultzCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 As usual it's hard to go wrong with a test case taken directly from the bug report.

@abayer abayer merged commit ca2b7cf into jenkinsci:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshultzCB kshultzCB kshultzCB approved these changes

@rsandell rsandell Awaiting requested review from rsandell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.1
2 participants
@abayer @kshultzCB