Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-37897] Switch to block scoped stages. #3

Merged
merged 1 commit into from Sep 1, 2016

Conversation

@abayer
Copy link
Member

commented Sep 1, 2016

JENKINS-37897

Also create synthetic stages for post-build and notifications. Maybe
more of those to come in the future, but haven't decided yet. Also
bumped plugin versions.

cc @reviewbybees @michaelneale @svanoort @jglick @oleg-nenashev

Also create synthetic stages for post-build and notifications. Maybe
more of those to come in the future, but haven't decided yet. Also
bumped plugin versions.
@reviewbybees

This comment has been minimized.

Copy link

commented Sep 1, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@svanoort

This comment has been minimized.

Copy link
Member

commented Sep 1, 2016

🐝 LGTM

@jglick

This comment has been minimized.

Copy link
Member

commented Sep 1, 2016

🐝

@abayer abayer merged commit b56726a into jenkinsci:master Sep 1, 2016
1 check passed
1 check passed
Jenkins This pull request looks good
Details
j.assertLogContains("I FAILED", b);

WorkflowJob job = b.getParent();
job.setDefinition(new CpsFlowDefinition(pipelineSourceFromResources("notificationOnChangeChanged")));
WorkflowRun b2 = job.scheduleBuild2(0).waitForStart();
j.assertBuildStatusSuccess(j.waitForCompletion(b2));
j.assertLogContains("Entering stage foo", b2);
j.assertLogContains("[Pipeline] { (foo)", b2);

This comment has been minimized.

Copy link
@michaelneale

michaelneale Sep 2, 2016

Member

what an odd change... but ok...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.