New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-39244, FIXED JENKINS-39245] Add env and tools to stages #40

Merged
merged 3 commits into from Oct 28, 2016

Conversation

Projects
None yet
3 participants
@abayer
Member

abayer commented Oct 25, 2016

JENKINS-39244, JENKINS-39245

Adds support for tools and environment sections inside individual stages.

cc @reviewbybees esp @stephenc @rsandell

[FIXED JENKINS-39244, FIXED JENKINS-39245] Add env and tools to stages
Adds support for tools and environment sections inside individual stages.
@reviewbybees

This comment has been minimized.

reviewbybees commented Oct 25, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@@ -204,6 +210,21 @@ public class ModelInterpreter implements Serializable {
}
}
def withEnvBlock(List<String> envVars, Closure body) {
System.err.println("IN WITHENV BLOCK WITH ${envVars}")

This comment has been minimized.

@rsandell

rsandell Oct 27, 2016

Member

remove

@@ -55,6 +55,16 @@ public void simpleEnvironment() throws Exception {
}
@Test
public void environmentInStage() throws Exception {
prepRepoWithJenkinsfile("environmentInStage");

This comment has been minimized.

@rsandell

rsandell Oct 27, 2016

Member
expect("environmentInStage").logContains("[Pipeline] { (foo)", "FOO is BAR").go()
@rsandell

This comment has been minimized.

Member

rsandell commented Oct 27, 2016

Only one missed debug print otherwise a be, but 🐛

@rsandell

This comment has been minimized.

Member

rsandell commented Oct 28, 2016

🐝

@rsandell

This comment has been minimized.

Member

rsandell commented Oct 28, 2016

it would be nice to get this merged asap so I don't have to redo half of the work I'm currently doing when it is.

@rsandell rsandell merged commit 83a83f6 into jenkinsci:master Oct 28, 2016

1 check failed

continuous-integration/jenkins/pr-merge Something is wrong with the build of this commit
Details
@rsandell

This comment has been minimized.

Member

rsandell commented Oct 28, 2016

Merged, cause I need it and I see no problems with it and no one else has for 24h.
We can always tweak later before 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment