Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-39134] Fix CreationException when resuming inside script {} #59

Merged
merged 5 commits into from Nov 30, 2016

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

commented Nov 29, 2016

JENKINS-39134

My initial thought was that a missing optional = true attribute on @Inject would solve the issue; but it did not, and that would not explain the withMaven problem anyway. At any rate, this fix works for this plugin, and I will track down the pipeline-maven bug separately.

@reviewbybees

@reviewbybees

This comment has been minimized.

Copy link

commented Nov 29, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer

This comment has been minimized.

Copy link
Member

commented Nov 29, 2016

Interesting. 🐝

@abayer
Copy link
Member

left a comment

Actually, 🐛 now that the TagsAction PR has been merged to master and the pipeline-stage-tags-metadata plugin has been added. I can obviously do that myself, but since you're already here, probably best to do it here so it's not forgotten.

@rsandell

This comment has been minimized.

Copy link
Member

commented Nov 30, 2016

🐝

@abayer

abayer approved these changes Nov 30, 2016

Copy link
Member

left a comment

🐝

@abayer abayer merged commit e27901b into jenkinsci:master Nov 30, 2016

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@jglick jglick deleted the jglick:CreationException-JENKINS-39134 branch Nov 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.