Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-28063] Handle redundant upstream builds #121

Merged
merged 2 commits into from May 4, 2015

Conversation

@jglick
Copy link
Member

commented Apr 30, 2015

jglick added 2 commits Apr 30, 2015
[FIXED JENKINS-28063] BuildTriggerAction must implement FoldableActio…
…n and multiple instances checked.

Otherwise any redundant upstream builds never receive notification of the downstream build’s completion, and hang.
@@ -8,16 +8,12 @@

import javax.annotation.Nonnull;

/**
* @author Vivek Pandey

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev May 4, 2015

Member

Is it a penalty for the missing Javadoc? :)

This comment has been minimized.

Copy link
@jglick

jglick May 4, 2015

Author Member

Ha! No, I just looked at this class and realized that essentially nothing of what he originally wrote remains unedited, so leaving the attribution there is just misleading. If you want to know what someone wrote, check Git history.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented May 4, 2015

👍

jglick added a commit that referenced this pull request May 4, 2015
Merge pull request #121 from jglick/coalesced-build-JENKINS-28063
[JENKINS-28063] Handle redundant upstream builds

@jglick jglick merged commit 1c8d22a into jenkinsci:master May 4, 2015

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:coalesced-build-JENKINS-28063 branch May 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.