Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-32670] Integration test #365

Merged

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

commented Mar 15, 2016

[JENKINS-32670] Integration test showing that branch property strateg…
…ies are hidden by default for multibranch Pipeline projects.
@reviewbybees

This comment has been minimized.

Copy link

commented Mar 15, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@kzantow

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2016

🐝 there must be a way to not depend on snapshots, though; or do you (or someone else) just go and update these all at the same time when they're published?

@@ -123,6 +127,7 @@
// RateLimitBranchProperty & BuildRetentionBranchProperty hidden by JobPropertyStep.HideSuperfluousBranchProperties.
// UntrustedBranchProperty hidden because it applies only to Project.
assertEquals(Collections.<Class<? extends BranchProperty>>emptySet(), clazzes);
assertEquals(Collections.<BranchPropertyStrategyDescriptor>emptyList(), r.jenkins.getDescriptorByType(BranchSource.DescriptorImpl.class).propertyStrategyDescriptors(p, r.jenkins.getDescriptorByType(SingleSCMSource.DescriptorImpl.class)));

This comment has been minimized.

Copy link
@amuniz

amuniz Mar 15, 2016

Member

I'm ready to see this line without scrolling.

image

@amuniz

This comment has been minimized.

Copy link
Member

commented Mar 15, 2016

🐝

@kzantow depending on snapshots is required when working with upstream changes. Once the upstream is released the snapshot is updated and this PR can be merged.

@jglick

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2016

Once the upstream is released the snapshot is updated and this PR can be merged.

Or I just merge with an @Ignore.

jglick added a commit that referenced this pull request Mar 16, 2016

@jglick jglick merged commit d75fc7c into jenkinsci:master Mar 16, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:branch-property-filtering-JENKINS-32670 branch Mar 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.