Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-42373] introduce StageListener #9

Closed
wants to merge 3 commits into from
Closed

[JENKINS-42373] introduce StageListener #9

wants to merge 3 commits into from

Conversation

ndeloof
Copy link

@ndeloof ndeloof commented Feb 28, 2017

@ndeloof
Copy link
Author

ndeloof commented Feb 28, 2017

@reviewbybees

@ghost
Copy link

ghost commented Feb 28, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No JIRA, no downstream PR demonstrating implementation, no description at all of what the purpose might be.

Anyway this is dead code unless you are using non-block-scoped stages, which is now deprecated.

* Any exception/error thrown from this method will be swallowed to prevent broken listeners
* from breaking all the builds.
*/
public abstract void onEnterred(Run run, String name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@ndeloof
Copy link
Author

ndeloof commented Feb 28, 2017

@jglick sample usage is in private code
created JENKINS-42373 to track this
I indeed didn't noticed the "block" part, I don't use this mode by myslef, I dislike it :P

@jglick jglick changed the title introduce StageListener [JENKINS-42373] introduce StageListener Feb 28, 2017
@jglick
Copy link
Member

jglick commented Feb 28, 2017

We already have FlowGraphListener which gives you much more information and is not limited to this step, so this API seems superfluous.

@ndeloof
Copy link
Author

ndeloof commented Feb 28, 2017

I never heard about this guy. HAve a link to FlowGraphListener.java ? github nor Google do know about it

@jglick
Copy link
Member

jglick commented Feb 28, 2017

GraphListener, sorry.

@ndeloof
Copy link
Author

ndeloof commented Feb 28, 2017

ok, thanks. Will need to understand how to use it.

@ndeloof ndeloof closed this Feb 28, 2017
@svanoort
Copy link
Member

@ndeloof Also there is a set of APIs in the workflow-api graphanalysis package and pipeline-graph-analysis plugin if you need to pick out stage information and do something with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants