New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-42373] introduce StageListener #9
Conversation
@reviewbybees |
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No JIRA, no downstream PR demonstrating implementation, no description at all of what the purpose might be.
Anyway this is dead code unless you are using non-block-scoped stage
s, which is now deprecated.
* Any exception/error thrown from this method will be swallowed to prevent broken listeners | ||
* from breaking all the builds. | ||
*/ | ||
public abstract void onEnterred(Run run, String name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
@jglick sample usage is in private code |
We already have |
I never heard about this guy. HAve a link to FlowGraphListener.java ? github nor Google do know about it |
|
ok, thanks. Will need to understand how to use it. |
@ndeloof Also there is a set of APIs in the workflow-api graphanalysis package and pipeline-graph-analysis plugin if you need to pick out stage information and do something with it. |
JENKINS-42373