Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate javadoc - fails on JDK 11.0.2 #42

Merged
merged 2 commits into from Jan 19, 2019

Conversation

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Jan 19, 2019

JENKINS-55692 - Don't build javadoc

Since this plugin does not intend to have any external callers or any external API consumers, don't generate javadoc. Resolves a Java 11.0.2 maven failure due to javadoc.

The failure message is:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc (default-cli) on project platformlabeler: An error has occurred in Javadoc report generation:
[ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR]
[ERROR] Command line was: /usr/lib/jvm/java-11-openjdk-amd64/bin/javadoc @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/home/mwaite/git/jenkins/platformlabeler-plugin/target/site/apidocs' dir.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No findbugs warnings were introduced with my changes

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)

Further comments

Other plugins will need to use a different technique.

Since this plugin does not intend to have any external callers or any
external API consumers, don't generate javadoc.  Resolves a Java 11.0.2
maven failure due to javadoc.  The failure message is:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc (default-cli) on project platformlabeler: An error has occurred in Javadoc report generation:
[ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR]
[ERROR] Command line was: /usr/lib/jvm/java-11-openjdk-amd64/bin/javadoc @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/home/mwaite/git/jenkins/platformlabeler-plugin/target/site/apidocs' dir.
@MarkEWaite MarkEWaite force-pushed the MarkEWaite:fix-java-11-javadoc branch from cad1256 to fd4f7b4 Jan 19, 2019
@MarkEWaite MarkEWaite merged commit 13d8b12 into jenkinsci:master Jan 19, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@MarkEWaite MarkEWaite deleted the MarkEWaite:fix-java-11-javadoc branch Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.