Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-19129] Use the TokenMacro plugin to allow filename to be a $variable #23

Closed
wants to merge 1 commit into from

Conversation

@bitsarvi
Copy link

commented Sep 11, 2015

Use the TokenMacro plugin to allow variables to be specified as the series filename. The token is not substituted in-place (as this will get written back to the config). Instead a new variable is used to store the real filename and this variable is used to locate the series data relative to the workspace.

[JENKINS-19129] Use the TokenMacro plugin to allow a variable to be
specified as the series filename. The token is not substituted
in-place (as this will get written back to the config). Instead a
new variable is used to store the real filename and this variable
is used to locate the series data relative to the workspace.

Initialize realfile to file
@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Sep 11, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@ericbn

This comment has been minimized.

Copy link
Member

commented Sep 30, 2016

@bitsarvi, can you please include unit tests for that?

@ericbn

This comment has been minimized.

Copy link
Member

commented Feb 28, 2017

This plugin is up for adoption. Want to help improve this plugin? Click here to learn more!

@vgaidarji

This comment has been minimized.

Copy link
Contributor

commented Nov 8, 2017

@bitsarvi Thanks a lot for your contribution. It's been a while since this PR was open. Are you going to bring it to the mergeable state?

  • you need to rebase your branch onto the master
  • review new .github/PULL_REQUEST_TEMPLATE
  • add unit tests as it's mandatory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.