Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for maven2/3 projects; updated plugin version #4

Merged
merged 3 commits into from Jan 16, 2014

Conversation

@thomasfox
Copy link

thomasfox commented Mar 14, 2013

Currently, the plot plugin can not be used in maven 2/3 projects.
However, I have discovered no real reason for this, all I had to do was exchanging AbstractProject for Project and AbstractBuild for Build.

Then, to check that the change also works for a current jenkins version, I have updated the jenkins plugin version to the new LTS jenkins version.

@buildhive

This comment has been minimized.

Copy link

buildhive commented Mar 14, 2013

Jenkins » plot-plugin #5 SUCCESS
This pull request looks good
(what's this?)

definition of Descriptor
- Extract Descriptor as top-level class
@buildhive

This comment has been minimized.

Copy link

buildhive commented Mar 15, 2013

Jenkins » plot-plugin #6 SUCCESS
This pull request looks good
(what's this?)

@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Jul 17, 2013

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@michaelayates

This comment has been minimized.

Copy link

michaelayates commented Nov 6, 2013

This patch seems to directly address https://issues.jenkins-ci.org/browse/JENKINS-8478

@ericbn

This comment has been minimized.

Copy link
Member

ericbn commented Nov 6, 2013

michaelayates,

yes, it fixes that issue. I just changed the code so the plugin won't be available to matrix projects, since this patch is not enough to make it work for this kind of project. I'm evaluating the pull request from lvotypko and gauthierde that seems to add matrix support for matrix projects.

I'm preparing a pull request with this and other fixes at #7

@ericbn ericbn merged commit a72cf6c into jenkinsci:master Jan 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.