Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-56312] Prevent adding splits with the wrong JDK #115

Merged
merged 4 commits into from Feb 28, 2019

Conversation

@raul-arabaolaza
Copy link
Contributor

commented Feb 27, 2019

JENKINS-56312 Only add splits with JDK field if testJDK is newer than the specified JDK version.

This is the first of two fixes to prevent failures related to the PCT adding jaxb plugin to builds outside of java 11, second one will make sure the added jaxb dependency uses the proper groupId instead of org.jenkins-ci.plugins

@Wadeck
Wadeck approved these changes Feb 27, 2019
Copy link

left a comment

🐝 empty PRs are the best!

@raul-arabaolaza

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

Ops, this is a mistake... fixing my PR now, is not going to be much bigger :P

@raul-arabaolaza raul-arabaolaza force-pushed the raul-arabaolaza:JENKINS-56312 branch from a7a959d to fca59b1 Feb 27, 2019
@raul-arabaolaza

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

@Wadeck Now you can review, as promised not much bigger :)

@Wadeck
Wadeck approved these changes Feb 28, 2019
Copy link

left a comment

The code seems fine. What you call split is a detached plugin, right?

Copy link
Member

left a comment

JavaSpecificationVersion should be used for the version comparison here. Some test automation would not hurt as well, but we could deliver a quick fix as is

Copy link
Member

left a comment

I agree with @oleg-nenashev about the Java version comparison.

Co-Authored-By: raul-arabaolaza <raul.arabaolaza@gmail.com>
@raul-arabaolaza

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

The code seems fine. What you call split is a detached plugin, right?

Exactly :)

@raul-arabaolaza raul-arabaolaza requested a review from oleg-nenashev Feb 28, 2019
Copy link
Member

left a comment

LGTM

@oleg-nenashev oleg-nenashev merged commit 7d59f12 into jenkinsci:master Feb 28, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@raul-arabaolaza raul-arabaolaza deleted the raul-arabaolaza:JENKINS-56312 branch Feb 28, 2019
batmat added a commit to batmat/plugin-compat-tester that referenced this pull request Apr 4, 2019
…-56312"

This reverts commit 7d59f12, reversing
changes made to 661782e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.