Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integration Tests + fixes for JENKINS-56312 and JENKINS-57320 #140

Merged
merged 8 commits into from May 3, 2019

Conversation

@batmat
Copy link
Member

commented Apr 19, 2019

Supersedes #133

@batmat batmat force-pushed the batmat:add-ITs-take-2 branch from 2d1d73c to 50365d3 Apr 19, 2019

@batmat batmat requested review from MRamonLeon and alecharp Apr 19, 2019

parallel(branches)

// Integration testing, using a locally built Docker image
def itBranches = [:]

This comment has been minimized.

Copy link
@batmat

batmat Apr 19, 2019

Author Member

There is definitely some level of copy paste below. I think we'll want to factor this out at some point.

But I didn't want to spend too much making this generic yet (like having a way to simply provide the command the pass, the expected result, etc.). I'd rather first have this merged as-is, once green, and we iterate on growing the test coverage and will refactor in followups.

@batmat batmat requested a review from raul-arabaolaza Apr 19, 2019

@batmat

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

The current ITs demonstrate AFAICT something does not work.
When I reverted #115 in #133, ITs would get back to green.

No time to dig into it now, but hopefully this will help us fix the situation now we can reproduce and track the expected behavior for PCT.

@MRamonLeon
Copy link

left a comment

Fine to merge it after running fine when the failure found is resolved.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Finally, the regression root cause is in #116 which was then improperly fixed in #131 . The latter fix actually prevents PCT from running properly on any community-provided jenkins.war

@oleg-nenashev oleg-nenashev changed the title [WIP] Add Integration Tests [WIP] Add Integration Tests + fixes for JENKINS-56312 and JENKINS-57320 May 3, 2019

@MRamonLeon

This comment has been minimized.

Copy link

commented May 3, 2019

Cool!!!!

Screenshot from 2019-05-03 15-53-01

@oleg-nenashev
Copy link
Member

left a comment

I think it is OK to merge as is, but it would be great to fix copy-paste

sh 'make docker'
}

stage('Download Jenkins 2.164.1') {

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev May 3, 2019

Member

Use 2.164.2?

}
}

itBranches['buildtriggerbadge:2.10 tests success on JDK8'] = {

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev May 3, 2019

Member

Would it be possible to prevent copy-paste ?

@oleg-nenashev
Copy link
Member

left a comment

approving it actually

@alecharp
Copy link
Member

left a comment

👏 🙇

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented May 3, 2019

We will fix the copy-paste later. Since PCT is broken, I will just merge it

@oleg-nenashev oleg-nenashev merged commit 9842626 into jenkinsci:master May 3, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@oleg-nenashev oleg-nenashev changed the title [WIP] Add Integration Tests + fixes for JENKINS-56312 and JENKINS-57320 Add Integration Tests + fixes for JENKINS-56312 and JENKINS-57320 May 3, 2019

@batmat batmat deleted the batmat:add-ITs-take-2 branch May 3, 2019

@oleg-nenashev oleg-nenashev added internal test and removed test labels Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.