Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest true respect pinned versions #359

Conversation

@Lakhtenkov-iv
Copy link
Contributor

@Lakhtenkov-iv Lakhtenkov-iv commented Aug 24, 2021

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

This should allow to install pinned version of the plugin even if it is lower than a plugin as a dependency for other plugins reqested.

Fixes #250

@timja
Copy link
Member

@timja timja commented Aug 24, 2021

Is there a reason this is draft? Is there something left to do?

@timja timja added the bug label Aug 24, 2021
Copy link
Member

@timja timja left a comment

looks good, one minor docs fix and once the tests are sorted we can ship this

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Lakhtenkov-iv Lakhtenkov-iv force-pushed the Lakhtenkov-iv:feature/latest-true-respect-pinned-versions branch from e1bb08d to 10bf833 Aug 24, 2021
Copy link
Member

@timja timja left a comment

formatting

@timja
timja approved these changes Aug 24, 2021
@timja
Copy link
Member

@timja timja commented Aug 24, 2021

anything pending? given you've got it in draft status

@Lakhtenkov-iv Lakhtenkov-iv marked this pull request as ready for review Aug 24, 2021
@Lakhtenkov-iv
Copy link
Contributor Author

@Lakhtenkov-iv Lakhtenkov-iv commented Aug 24, 2021

anything pending? given you've got it in draft status

No, marked as Ready

@timja timja merged commit e4d3773 into jenkinsci:master Aug 24, 2021
13 checks passed
13 checks passed
@ci-jenkins-io
CPD No issues.
Details
@ci-jenkins-io
CheckStyle No issues.
Details
@ci-jenkins-io
Java Compiler No issues.
Details
@ci-jenkins-io
JavaDoc 3 new issues, 14 total.
Details
@ci-jenkins-io
Jenkins Success
Details
@ci-jenkins-io
Maven 6 new issues, 21 total.
Details
@ci-jenkins-io
Open Tasks Scanner No new issues, 8 total.
Details
@ci-jenkins-io
PMD No issues.
Details
@ci-jenkins-io
SpotBugs No issues.
Details
@ci-jenkins-io
Tests / linux-11 / Build (linux-11) skipped: 2, passed: 158
Details
@ci-jenkins-io
Tests / linux-8 / Build (linux-8) skipped: 2, passed: 158
Details
@ci-jenkins-io
Tests / windows-11 / Build (windows-11) skipped: 4, passed: 156
Details
@jenkinsadmin
continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants