Correct version extraction from manifest with optional plugins #360
Conversation
endakelly
approved these changes
Aug 25, 2021
msl8r
approved these changes
Aug 25, 2021
timja
added a commit
that referenced
this issue
Aug 25, 2021
![@ci-jenkins-io[bot]](https://avatars.githubusercontent.com/in/74951?v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Incrementals now resolve dependencies correctly when there is an optional plugin
Previously I was getting:
This was because the version was set to '2.46;resolution', due to resolution=optional being on the line that was being split.
The tests had captured this mistake😢
The text was updated successfully, but these errors were encountered: