Parallel downloading #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Jul 25, 2019
| @@ -194,13 +194,13 @@ public void outputFailedPlugins() { | |||
| * @param plugins list of plugins to download | |||
| */ | |||
| public void downloadPlugins(List<Plugin> plugins) { | |||
| for (Plugin plugin : plugins) { | |||
| plugins.parallelStream().forEach(plugin -> { | |||
There was a problem hiding this comment.
can you run it on your setup and see if it helps 馃槃
There was a problem hiding this comment.
That was the plan! I am just abusing Jenkins CI to get the jar 馃槄
There was a problem hiding this comment.
Holy crap 馃檶
real 1m 6.93s
user 0m 8.98s
sys 0m 1.86s
I think we can optimize it even more if we play with custom thread pool and just doing it on all available cores (+hyper threading)
There was a problem hiding this comment.
but reading up on optimizing I would say NOPE 馃槄
timja
approved these changes
Jul 25, 2019
|
Okay after fixing #50 the full download takes Still a huge improvement but I think we can do better! |
|
I'd say let's merge this at least and then we can worry about improving the download even more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully, this should speed up downloads 馃槄
time diff I did on our plugins.txt:
.jar after:
.jar before:
.sh: