Please sign in to comment.
JENKINS-29369 Fix locale dependent accumulated msg
The accumulated commit message is now using english locale when formatting date and time. The commit message is generated by the plugin and formatted to look like the squash commit message except for the header line. Tests have been improved to include detailed commit message asserts and extend to include few more tests for squashed also. Each test now verifies that the formatting of dates are correct for the tests regarding special charecters and custom integration branch (those were the newer tests we added so the follow a better design). Other improvements and refactoring: - removed un-used code in squash commit strategy - removed debug print of squash commit strategy to build console - add debug printing of exception during integration to the build console - fixed minor bug in test utils regarding printing console which is null - test base class for static git repos extended to print out cleaning repos and temp files
- Loading branch information...
Showing with 338 additions and 93 deletions.
- +20 −0 README.md
- +2 −0 src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/AccumulatedCommitStrategy.java
- +7 −2 ...main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/GetAllCommitsFromBranchCallback.java
- +11 −17 src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/SquashCommitStrategy.java
- +2 −3 ...est/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/BuildResultValidator.java
- +276 −66 .../jenkinsci/plugins/pretestedintegration/integration/scm/git/CommitMessagesWithSpecialCharsIT.java
- +4 −1 ...ava/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/CustomIntegrationBranchIT.java
- +14 −3 ...a/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/StaticGitRepositoryTestBase.java
- +2 −1 src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/TestUtilsFactory.java
Oops, something went wrong.