Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards 2.3 #10

Merged
merged 25 commits into from Dec 20, 2013

Conversation

Projects
None yet
4 participants
@emsa23
Copy link

emsa23 commented Dec 8, 2013

Refactoring to cache more info about the Queue.Items
Moved startup-sequence to one place to control startup flow
Using the cache for Matrix lookups

emsa23 added some commits Dec 7, 2013

Sorter now caches more info about Queue.Item
 * Cache moved to new class (QueueItemCache)
 * Cache uses WeakHash to cache data after item left Queue
 * Caches more info about the item to minimize need for re-lookup
(ItemInfo)
Added PrioritySorterPLugin and moved initialization
All initialization is now done from the PrioritySorterPlugin
this includes legacy check and initial queue sorting.
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Dec 8, 2013

plugins » priority-sorter-plugin #54 SUCCESS
This pull request looks good

emsa23 added some commits Dec 8, 2013

Added UpstreamCauseStrategy.
This strategy will give the triggered Job the same priority
as the Build it got triggered by.
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Dec 8, 2013

plugins » priority-sorter-plugin #55 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Dec 8, 2013

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Dec 8, 2013

It makes sense to track new features/bugs in Jenkins JIRA.
Such approach greatly simplifies further analysis of issues.

emsa23 added some commits Dec 8, 2013

Removed ActualAdvancedQueueSorterJobProperty.
Removed ActualAdvancedQueueSorterJobProperty now uses 
QueueItemCache, this reduces Job-lookups and iterations 
over all Jobs that was used before.
Refactoring to use callback/service pattern for assigning values.
Revering flow to be able to provide several values to 
the caller.
[JENKINS-11997] Consider jobs in the Executors for priority sorter
Introducing "Run Exclusive", with "Run Exclusive" set on a 
JobGroup only Jobs from that JobGroup will be started
until no more Jobs from that JobGroup is in queue being run.
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Dec 9, 2013

plugins » priority-sorter-plugin #56 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Dec 9, 2013

plugins » priority-sorter-plugin #57 SUCCESS
This pull request looks good

emsa23 added some commits Dec 12, 2013

[JENKINS-20995] Default Priority always shows 1-5
Fixed problem where Default Priority Dropdown
always showed 1-5.
Updated default handling to reuse set values 
when switching strategy.
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Dec 12, 2013

plugins » priority-sorter-plugin #58 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Dec 14, 2013

plugins » priority-sorter-plugin #59 SUCCESS
This pull request looks good

emsa23 added some commits Dec 14, 2013

[TEST] Assert Jobs start order.
Added feature to assert that Jobs gets started
in the expected order.
[TEST] Added simple test framework
Started with a simple framework for scheduling Jobs 
and validation the priority and start order.
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Dec 15, 2013

plugins » priority-sorter-plugin #60 UNSTABLE
Looks like there's a problem with this pull request

[TEST] Changed timing and setup.
Changed timing so that Jobs are clearly separated 
in time. Made sure tests runs with one  executer to 
avoid races when starting builds.
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Dec 15, 2013

plugins » priority-sorter-plugin #61 SUCCESS
This pull request looks good

emsa23 added some commits Dec 15, 2013

[TEST] Prevent the Jobs being started until sorted.
PRevent the Jobs from beeing started until we know
they are correctly sorted. HAd to use a reload() of
Jenkins to make the config take effect.
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Dec 15, 2013

plugins » priority-sorter-plugin #62 UNSTABLE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Dec 15, 2013

plugins » priority-sorter-plugin #63 SUCCESS
This pull request looks good

emsa23 added a commit that referenced this pull request Dec 20, 2013

@emsa23 emsa23 merged commit b5858f3 into jenkinsci:master Dec 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.