Skip to content
Permalink
Browse files

[FIXED JENKINS-27716] - Disable archived promotion jobs

Since 1.585, the promotion must explicitly indicate that it can be disabled.
Otherwise, promotions which trigger automatically upon build completion will
execute, even if they're archived.

See hudson.model.AbstractProject#makeDisabled(boolean) for additional details.
  • Loading branch information
Benjamin Heiskell
Benjamin Heiskell committed Nov 11, 2015
1 parent 524772c commit 2a33fc613bc74a4cdaca88c1c352b9d79ce7678a
Showing with 9 additions and 0 deletions.
  1. +9 −0 src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java
@@ -153,6 +153,15 @@ public JobPropertyImpl getParent() {
return getOwner().getACL();
}

/**
* JENKINS-27716: Since 1.585, the promotion must explicitly indicate that
* it can be disabled. Otherwise, promotions which trigger automatically
* upon build completion will execute, even if they're archived.
*/
@Override public boolean supportsMakeDisabled() {
return true;
}

/**
* Get the promotion condition by referencing it fully qualified class name
*/

0 comments on commit 2a33fc6

Please sign in to comment.
You can’t perform that action at this time.