Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Pass through all the build actions #12

Closed
wants to merge 1 commit into from

3 participants

@beckje01

Adjusted scheduleBuild to pass through all the build actions to the promotion build. This change is passing all the tests and allows the pass the git revision through to another build using the parameterized build plugin.

https://groups.google.com/d/topic/jenkinsci-dev/VFQsTn1lAF8/discussion

@kohsuke
Owner

I hate to be difficult (especially so after so much delay!) but I feel this is also bit problematic.

The main issue here is that Actions are generally used to represent things that have happened during a build. So copying them all would make promotion process to run in a bit weird environment, and it makes the other code think that promotion process run stuff that actually didn't run.

I'll fix the Git plugin to refer to the root build as I originally suggested. I think it works in other contexts well, such as matrix project.

@beckje01 beckje01 closed this
@beckje01

The fix being on the Git plugin seems correct I am closing this pull request.

@ashelley

Hello,

I am using

-Jenkins 1.480.3
-Jenkins GIT client plugin version 1.0.5
-Promoted Build Plugin version 2.8

I have a job "Build when another project is promoted".

It actually does not use the promoted revision but a later revision which may have had a failure. This feature doesn't seem to be working in the git plugin. Is there anything I need to configure to make this work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 1, 2011
  1. @beckje01
This page is out of date. Refresh to see the latest.
View
8 src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java
@@ -302,13 +302,13 @@ public boolean scheduleBuild(AbstractBuild<?,?> build) {
public boolean scheduleBuild(AbstractBuild<?,?> build, Cause cause) {
assert build.getProject()==getOwner();
- // Get the parameters, if any, used in the target build and make these
- // available as part of the promotion steps
- List<ParametersAction> parameters = build.getActions(ParametersAction.class);
+ //Get all of the builds actions
+ List<Action> buildsActions = build.getActions();
+
// Create list of actions to pass to scheduled build
List<Action> actions = new ArrayList<Action>();
- actions.addAll(parameters);
+ actions.addAll(buildsActions); //Pass through the original actions
actions.add(new PromotionTargetAction(build));
// remember what build we are promoting
Something went wrong with that request. Please try again.