Skip to content

Pass through all the build actions #12

Closed
wants to merge 1 commit into from

3 participants

@beckje01
beckje01 commented Sep 2, 2011

Adjusted scheduleBuild to pass through all the build actions to the promotion build. This change is passing all the tests and allows the pass the git revision through to another build using the parameterized build plugin.

https://groups.google.com/d/topic/jenkinsci-dev/VFQsTn1lAF8/discussion

@kohsuke
Jenkins member
kohsuke commented Jun 22, 2012

I hate to be difficult (especially so after so much delay!) but I feel this is also bit problematic.

The main issue here is that Actions are generally used to represent things that have happened during a build. So copying them all would make promotion process to run in a bit weird environment, and it makes the other code think that promotion process run stuff that actually didn't run.

I'll fix the Git plugin to refer to the root build as I originally suggested. I think it works in other contexts well, such as matrix project.

@beckje01 beckje01 closed this Jun 26, 2012
@beckje01

The fix being on the Git plugin seems correct I am closing this pull request.

@ashelley

Hello,

I am using

-Jenkins 1.480.3
-Jenkins GIT client plugin version 1.0.5
-Promoted Build Plugin version 2.8

I have a job "Build when another project is promoted".

It actually does not use the promoted revision but a later revision which may have had a failure. This feature doesn't seem to be working in the git plugin. Is there anything I need to configure to make this work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.