New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-31356] Manual condition and re-execute promotion bug. #70

Merged
merged 2 commits into from Nov 21, 2015

Conversation

Projects
None yet
3 participants
@shinstudio
Copy link
Contributor

shinstudio commented Nov 3, 2015

https://issues.jenkins-ci.org/browse/JENKINS-31356

doBuild method checks an user for only project permission level. It has to check the user for the approver list as well.

[JENKINS-31356] Manual condition and re-execute promotion bug. doBuil…
…d checked an user for only project permission level when it had to check the approver list as well
@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Nov 3, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@@ -129,7 +130,7 @@ public boolean canApprove(PromotionProcess promotionProcess, AbstractBuild<?,?>
/*
* Check if user is listed in user list as a specific user
*/
private boolean isInUsersList() {
public boolean isInUsersList() {

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Nov 11, 2015

Member

Makes sense. Could you also add @since TODO to Javadoc?

if(!getTarget().hasPermission(Promotion.PROMOTE))
return;

ManualCondition manualCondition=(ManualCondition) getProcess().getPromotionCondition(ManualCondition.class.getName());

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Nov 11, 2015

Member

I suppose null checks are missing here

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Nov 11, 2015

Looks good to me in general. Minor fixes can be applied during the merge

@oleg-nenashev oleg-nenashev added this to the 2.24 milestone Nov 11, 2015

oleg-nenashev added a commit that referenced this pull request Nov 21, 2015

Merge pull request #70 from shinstudio/master
[JENKINS-31356] Manual condition and re-execute promotion bug.

@oleg-nenashev oleg-nenashev merged commit 069d9fd into jenkinsci:master Nov 21, 2015

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment