Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-49083] - Make the plugin compatible with Jenkins 2.102+ #4

Merged
merged 5 commits into from Jan 24, 2018

Conversation

@oleg-nenashev
Copy link
Member

commented Jan 23, 2018

https://issues.jenkins-ci.org/browse/JENKINS-49083

  • - Make the plugin runnable with PCT by small pom.xml changes
  • - Fix the issue when a non-whitelisted class get serialized to the disk and loaded from there

@reviewbybees @jglick

@oleg-nenashev oleg-nenashev requested a review from jglick Jan 23, 2018

@jglick
jglick approved these changes Jan 23, 2018
@@ -0,0 +1,2 @@
// Build the plugin using https://github.com/jenkins-infra/pipeline-library
buildPlugin()

This comment has been minimized.

Copy link
@jglick

jglick Jan 23, 2018

Member

include 2.102 to prove the fix

@rinrinne

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

Thx for this PR. I can merge this if test is OK on your local environment. I will fix issues on CI server after that.

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2018

@rinrinne I have no environment for that. Asked the issue reporter to test it (see https://issues.jenkins-ci.org/browse/JENKINS-49083)

P.S: There are still Javadoc issues

@rinrinne

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

@rinrinne I have no environment for that.

Aren't you running "mvn test" on your PR?? How did you verify your added test case? Compile only?

P.S: There are still Javadoc issues

Unfortunately I have never seen javadoc issues because I'm compiling this plugin with JDK7. The reason why you or CI are seeing javadoc issue is that doclint feature is enabled by default in javadoc for JDK8.

@rinrinne

This comment has been minimized.

Copy link
Member

commented Jan 24, 2018

Hmm, I built this with JDK8, but no javadoc issues found.

$ mvn --batch-mode --errors --update-snapshots -Dmaven.test.failure.ignore clean install
(snip)
[INFO] --- maven-enforcer-plugin:3.0.0-M1:display-info (display-info) @ rabbitmq-consumer ---
[INFO] Maven Version: 3.5.2
[INFO] JDK Version: 1.8.0_151 normalized as: 1.8.0-151
[INFO] OS Info: Arch: amd64 Family: unix Name: linux Version: 4.10.0-42-generic
(snip)
[INFO] <<< maven-javadoc-plugin:2.10.4:javadoc (default) < generate-sources @ rabbitmq-consumer <<<
[INFO] 
[INFO] 
[INFO] --- maven-javadoc-plugin:2.10.4:javadoc (default) @ rabbitmq-consumer ---
[INFO] 

No errors or warnings were produced... I checked my local settings.xml but no related configurations.

How to reproduce javadoc issue locally?

@rinrinne

This comment has been minimized.

Copy link
Member

commented Jan 24, 2018

Identified issue. I switched JDK from bundled OpenJDK 8 to Oracle JDK 8 Then build again. Issue can be reproduced.

$ mvn --batch-mode --errors --update-snapshots -Dmaven.test.failure.ignore clean install
(snip)
[INFO] --- maven-enforcer-plugin:3.0.0-M1:display-info (display-info) @ rabbitmq-consumer ---
[INFO] Maven Version: 3.5.2
[INFO] JDK Version: 1.8.0_161 normalized as: 1.8.0-161
[INFO] OS Info: Arch: amd64 Family: unix Name: linux Version: 4.10.0-42-generic
[INFO] 
(snip)
[INFO] <<< maven-javadoc-plugin:2.10.4:javadoc (default) < generate-sources @ rabbitmq-consumer <<<
[INFO] 
[INFO] 
[INFO] --- maven-javadoc-plugin:2.10.4:javadoc (default) @ rabbitmq-consumer ---
[INFO] 
2 errors
4 warnings

Seems javadoc's doclint feature is enabled by default in Oracle JDK8, but disabled in distribution bundled OpenJDK 8. I'm using Ubuntu 16.04.

Has this kind of Java environment issue already been shared within Jenkins community??

@rinrinne

This comment has been minimized.

Copy link
Member

commented Jan 24, 2018

Anyway, I could pass added unit test with OpenJDK8. So I will merge this. Javadoc issue will be fixed later.
(disable doclint explicitly as short term solution)

@rinrinne rinrinne merged commit cf6a6ab into jenkinsci:master Jan 24, 2018

1 check failed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.