Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-20797] - Rework handling of Users in RecentReleasesPortlet #18

Merged
merged 1 commit into from Sep 28, 2016

Conversation

Projects
None yet
6 participants
@oleg-nenashev
Copy link
Member

oleg-nenashev commented Sep 28, 2016

Supersedes #6

  • Support both UserIdCause and the legacy UserCause (JENKINS-20797)
  • Do not create users during the lookup
  • Use Jenkins core API instead of the obsolete Mailer one

@reviewbybees @jenkinsci/code-reviewers @amuniz

[FIXED JENKINS-20797] - Rework handling of Users in RecentReleasesPro…
…tlet

* Support both UserIdCause and the legacy UserCause
* Do not create users during the lookup
* Use Jenkins core API instead of the obsolete Mailer one
@scoheb

This comment has been minimized.

Copy link

scoheb commented Sep 28, 2016

+1

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Sep 28, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@rsandell
Copy link
Member

rsandell left a comment

🐛 looks like an over use of final

} else if (cause instanceof UserCause) {
userName = ((UserCause)cause).getUserName();
} else {
userName = null;

This comment has been minimized.

Copy link
@rsandell

rsandell Sep 28, 2016

Member

Won't work unless the first cause is any of the two user causes, if the first cause is something else you won't be able to set it in the next loop around. Effectively you are only looking at the first cause in the list.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Sep 28, 2016

Author Member

WDYM? It's a local final variable within the loop.

This comment has been minimized.

Copy link
@rsandell

rsandell Sep 28, 2016

Member

Ah, yes. Sorry I saw it as outside of the loop. Sorry for the confusion.

@rsandell
Copy link
Member

rsandell left a comment

🐝

@jglick

jglick approved these changes Sep 28, 2016

Copy link
Member

jglick left a comment

🐝

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

oleg-nenashev commented Sep 28, 2016

@oleg-nenashev oleg-nenashev merged commit d9294ef into jenkinsci:master Sep 28, 2016

1 check passed

Jenkins This pull request looks good
Details
@amuniz

This comment has been minimized.

Copy link
Member

amuniz commented Sep 29, 2016

Belated 🐝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.