Skip to content

Channel initialization span#49

Merged
Aki-7 merged 1 commit intojenkinsci:mainfrom
Aki-7:channel-initialization-span
Jul 5, 2021
Merged

Channel initialization span#49
Aki-7 merged 1 commit intojenkinsci:mainfrom
Aki-7:channel-initialization-span

Conversation

@Aki-7
Copy link
Member

@Aki-7 Aki-7 commented Jun 22, 2021

close #41
ref #40

What I did

  • Enable to collect Channel Initialization Span
    • Only for JNLP inbound connection
    • Channel Initialization Span is between the first TCP handshaking begins and the org.hudson.Channel is connected
    • Contains following the child spans
      • Jnlp Endpoint Resolving Span
      • Jnlp Initialization Span
        • between the JNLP starts and org.hudson.Channel is connected or the JNLP fails
    • According to the JIRA ticket survey, unexpected Jnlp endpoint resolution causes problems, especially under the special network environment, e.g., HTTP Proxy, SSH Tunnel. And that's why I create Jnlp Endpoint Resolving Span

Limitation

Some spans are not precise enough as I only use the already-existing listener functionality in the remoting module.
To collect more spans more precisely, I'm going to create a PR for the remoting modules.

Demo

I disconnected and reconnected the agent several times to produce Channel Initialization spans.

Jaeger

list

Screen Shot 2021-06-22 at 20 23 12

each span

Screen Shot 2021-06-22 at 20 14 23

details

Protocol, port and host can be seen

Screen Shot 2021-06-25 at 15 35 53

Zipkin

Screen Shot 2021-06-22 at 20 17 54

Checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • All follow-ups are documented as issues and-or TODO comments
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue
  • Please update user documentation if needed
  • Please update developer documentation if needed

@Aki-7 Aki-7 requested a review from a team as a code owner June 22, 2021 11:24
@Aki-7 Aki-7 requested review from darshank15 and removed request for a team June 22, 2021 11:24
@Aki-7 Aki-7 force-pushed the channel-initialization-span branch from a400ebf to 236ce37 Compare June 22, 2021 11:34
@Aki-7 Aki-7 force-pushed the channel-initialization-span branch from 236ce37 to c7bcaa8 Compare June 25, 2021 06:34
@Aki-7 Aki-7 merged commit c72ebaf into jenkinsci:main Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make more helpful and short span (Channel Keep-Alive span)

1 participant