Filter metrics by regular expression#80
Merged
Aki-7 merged 1 commit intojenkinsci:mainfrom Aug 9, 2021
Merged
Conversation
oleg-nenashev
approved these changes
Aug 9, 2021
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
No objections w.r.t the pattern
|
|
||
| String metricsFilterPatternString = System.getenv("REMOTING_OTEL_METRIC_FILTER"); | ||
| Pattern metricsFilterPattern; | ||
| if (metricsFilterPatternString == null) metricsFilterPatternString = ".*"; |
Member
There was a problem hiding this comment.
It might be more efficient to pass the null pattern and to handle it as separate case
Member
Author
There was a problem hiding this comment.
I see, but it does the pattern evaluation only once for each metric at the registration phase, and I couldn't come up with a better way to achieve this without redundant code. So I will merge this PR as it is and I'll fix this later if the efficiency seems to be a problem. Thank you for your review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What metrics to collect is different from user to user, and this enables users to filter metrics to collect by regular expression.
The regular expression will be specified by
REMOTING_OTEL_METRIC_FILTERenvironment variables.The metrics whose name match the specified regex will be collected.
close #73
Checklist