From fe2587b7f9d78334e0ab05ab0b95f39b4b600a25 Mon Sep 17 00:00:00 2001 From: Oleg Nenashev Date: Mon, 6 Mar 2017 15:06:29 +0100 Subject: [PATCH] Docs - Noting JENKINS-37302, JENKINS-33886, and JENKINS-34121 in Errata --- docs/protocols.md | 17 +++++++++++++++-- .../remoting/engine/JnlpProtocol3Handler.java | 2 ++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/docs/protocols.md b/docs/protocols.md index 01e216a55..f040555c7 100644 --- a/docs/protocols.md +++ b/docs/protocols.md @@ -29,8 +29,9 @@ The protocol supports the non-blocking I/O, which improve the performance of the ### JNLP3-connect * Introduced in: Remoting 2.53, [JENKINS-26580](https://issues.jenkins-ci.org/browse/JENKINS-26580) -* The protocol has known stability issues and disabled by default in Jenkins -* Not recommended for use since the JNLP4-connect release +* The protocol has known stability issues (see the Errata section below) +* The protocol is disabled by default in Jenkins +* **Not recommended** for use since the JNLP4-connect release This protocol aims to improve security of JNLP-based slaves. Both the master and the slave securely authenticate each other and then setup an encrypted channel. @@ -40,6 +41,18 @@ For each connection a new thread is being created, and it leads to the performan even Denial of Service on highly loaded Jenkins masters. There are also some reported issues regarding the Remoting 3 stability on particular systems. +#### JNLP3-connect Errata + +Below you can find the list of known `JNLP3-connect` issues. +There is no plan to fix these issues, usage of `JNLP4-connect` is the recommended approach. + +* [JENKINS-37302](https://issues.jenkins-ci.org/browse/JENKINS-37302) - +JNLP3 challenge response generates invalid string encoding, the check may fail randomly. +* [JENKINS-33886](https://issues.jenkins-ci.org/browse/JENKINS-33886) - +On some configurations only one JNLP3 slave per IP address can be connected. +* [JENKINS-34121](https://issues.jenkins-ci.org/browse/JENKINS-34121) - +JNLP3 cannot be used on IBM Java, which doesn't support AES/CTR/PKCS5Padding. + ### JNLP4-connect * Introduced in: Remoting 3.0, [JENKINS-36871](https://issues.jenkins-ci.org/browse/JENKINS-36871) diff --git a/src/main/java/org/jenkinsci/remoting/engine/JnlpProtocol3Handler.java b/src/main/java/org/jenkinsci/remoting/engine/JnlpProtocol3Handler.java index 453965ee9..c9dc81aa3 100644 --- a/src/main/java/org/jenkinsci/remoting/engine/JnlpProtocol3Handler.java +++ b/src/main/java/org/jenkinsci/remoting/engine/JnlpProtocol3Handler.java @@ -119,6 +119,8 @@ * Java Cryptography Extension available. In the future maybe the key * size could be made a parameter or the implementation can check to see if * 256bit sizes are supported. + * + * @deprecated Deprecated after the release of JNLP4, see {@link JnlpProtocol4Handler} */ @Deprecated public class JnlpProtocol3Handler extends LegacyJnlpProtocolHandler {