Permalink
1 comment
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
[FIXED JENKINS-20769]
When ProxyWriter is finalized, it should attempt to release a remote reference count, but it shouldn't try to close the stream. For one, the other side that had exported the writer might be still using it (imagine exporting System.out), and secondly, the said object could have already been unexported, for example if the closure that brought ProxyWriter to this side has already returned, since RemoteWriter is auto-unexporting. Compare ProxyOutputStream impl vs ProxyWriter impl and the difference becomes clearer.
- Loading branch information
Showing
with
38 additions
and 1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96c670d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW commit comment should started with
[JENKINS-20769]
rather than[FIXED JENKINS-20769]
since the JIRA link daemon is not smart enough to know that the new version has to be integrated intojenkinsci/jenkins
for the fix to take effect.