Skip to content

[JENKINS-8676] Windows XP slave stopped working in 1.396 (related to name change) #1024

Closed

Description

@jenkins-infra-bot

See https://groups.google.com/d/topic/jenkinsci-dev/h3K8KbLvwKQ/discussion for discussion

It appears that some code hasn't been properly in ManagedWindowsServiceLauncher.java


Originally reported by lacostej, imported from: Windows XP slave stopped working in 1.396 (related to name change)
  • status: Resolved
  • priority: Blocker
  • component(s): remoting
  • resolution: Fixed
  • resolved: 2011-02-04T22:43:53+00:00
  • votes: 2
  • watchers: 2
  • imported: 2025-11-25
Raw content of original issue

See https://groups.google.com/d/topic/jenkinsci-dev/h3K8KbLvwKQ/discussion for discussion

It appears that some code hasn't been properly in ManagedWindowsServiceLauncher.java

Activity

  1. jenkins-infra-bot commented on Feb 3, 2011

    @jenkins-infra-bot
    Author
    lacostej:

    I have made a tentative fix here: lacostej/jenkins@2332b11

    Comments appreciated.

  2. jenkins-infra-bot commented on Feb 4, 2011

    @jenkins-infra-bot
    Author
    axelheider:
    • Original comment link
    • Raw content of original comment:

      Same Problem here (Windows Master, Windows Slave)

      Connecting to xxx Checking if Java exists java full version "1.6.0_22-b04" Installing the Jenkins slave service Copying jenkins-slave.exe

      An then nothing happens. On the Windows Slave no files arrive.

    Same Problem here (Windows Master, Windows Slave)

    Connecting to xxx
    Checking if Java exists
    java full version "1.6.0_22-b04"
    Installing the Jenkins slave service
    Copying jenkins-slave.exe

    An then nothing happens. On the Windows Slave no files arrive.

  3. jenkins-infra-bot commented on Feb 4, 2011

    @jenkins-infra-bot
    Author
    lacostej:

    Axel, if you want, I have a private build you might want to try (I still have to test the disconection and shutdown of the service part).

    Please also answer the following questions:

    • what is the name of the service on your windows slave (before and after upgrade) and after shutdown of the slaves

    http://coffeebreaks.org/software/jenkins/jenkins-1.397-lacostej-master-2332b114a38b6e62a8f28b40d4374b9e1d353de5.war

    MD5 7a9fe72d2b526457c3e9715e2123a4e8

    (Contains a few other fixes as well. See https://github.com/lacostej/jenkins/ for details.)

    Let me know how it goes !

  4. jenkins-infra-bot commented on Feb 4, 2011

    @jenkins-infra-bot
    Author
    axelheider:
    • Original comment link
    • Raw content of original comment:

      I've cleaned up the Windows slave and deleted the old Husdon service. The name was

      Hudson Service at [Drive]:\[Path]\[Path]...
      

      Furthermore I've uninstalled the Hudson service on the Windows Master and installed a jenkins Service via the GUI. Now I want to cleanyl set up a Jenkons slave machine.

      I will test your new war.

    I've cleaned up the Windows slave and deleted the old Husdon service. The name was

    Hudson Service at [Drive]:\[Path]\[Path]...
    
    

    Furthermore I've uninstalled the Hudson service on the Windows Master and installed a jenkins Service via the GUI. Now I want to cleanyl set up a Jenkons slave machine.

    I will test your new war.

  5. jenkins-infra-bot commented on Feb 4, 2011

    @jenkins-infra-bot
    Author
    axelheider:
    • Original comment link
    • Raw content of original comment:

      You build appears to work fine. The Windows slave is back online again and busily building. Thanks very much.

    You build appears to work fine. The Windows slave is back online again and busily building.
    Thanks very much.

  6. jenkins-infra-bot commented on Feb 4, 2011

    @jenkins-infra-bot
    Author
    pablaasmo:
    • Original comment link
    • Raw content of original comment:

      I works for windows XP for me also. So I guess this issue can be marked as resolved.

      I still have some problems with WIndows 7 64-bit with some access denied, but that is another issue (4929 I think). I though it was solved in release 1.387 "* Install as a service" now supports Vista and Windows 7. " but apparently not for 64-bit.

    I works for windows XP for me also. So I guess this issue can be marked as resolved.

    I still have some problems with WIndows 7 64-bit with some access denied, but that is another issue (4929 I think).
    I though it was solved in release 1.387 "* Install as a service" now supports Vista and Windows 7. " but apparently not for 64-bit.

  7. jenkins-infra-bot commented on Feb 4, 2011

    @jenkins-infra-bot
    Author
    lacostej:
    • Original comment link
    • Raw content of original comment:

      OK let me cleanup the patch and I will submit it. Thanks for your help

    OK let me cleanup the patch and I will submit it. Thanks for your help

  8. jenkins-infra-bot commented on Feb 4, 2011

    @jenkins-infra-bot
    Author
    scm_issue_link:
    • Original comment link
    • Raw content of original comment:

      Code changed in jenkins User: Jerome Lacoste Path: core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java http://jenkins-ci.org/commit/core/f40b4ffbc8e33e2624bcee9e5ced5c10f25d5426 Log: JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)

      After thinking about it, I don't want to deal with hudsonslave here. jenkinsslave should be found anyway, so that code path should not have been triggered. And cleaning up residual services isn't jenkins job. Otherwise both can't coexist.

    Code changed in jenkins
    User: Jerome Lacoste
    Path:
    core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java
    http://jenkins-ci.org/commit/core/f40b4ffbc8e33e2624bcee9e5ced5c10f25d5426
    Log:
    JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)

    After thinking about it, I don't want to deal with hudsonslave here. jenkinsslave should be found anyway, so that code path should not have been triggered.
    And cleaning up residual services isn't jenkins job. Otherwise both can't coexist.

  9. jenkins-infra-bot commented on Feb 8, 2011

    @jenkins-infra-bot
    Author
    scm_issue_link:
    • Original comment link
    • Raw content of original comment:

      Code changed in jenkins User: Jerome Lacoste Path: core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java http://jenkins-ci.org/commit/core/2332b114a38b6e62a8f28b40d4374b9e1d353de5 Log: JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)

      The ManagedWindowsServiceLauncher refers to hudson.exe and hudson-slave.exe while we renamed the artifact to jenkins.exe.

      Tentative fix, completely untested (no windows box around). Not sure about the service name (jenkinsslave). I added a second check for backward compatibility but I have no idea if it's useful.

    Code changed in jenkins
    User: Jerome Lacoste
    Path:
    core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java
    http://jenkins-ci.org/commit/core/2332b114a38b6e62a8f28b40d4374b9e1d353de5
    Log:
    JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)

    The ManagedWindowsServiceLauncher refers to hudson.exe and hudson-slave.exe while we renamed the artifact to jenkins.exe.

    Tentative fix, completely untested (no windows box around).
    Not sure about the service name (jenkinsslave). I added a second check for backward compatibility but I have no idea if it's useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions