Repository navigation
[JENKINS-48778] JNLP not considering plain hostnames when evaluating NO_PROXY #1297
Description
Encountering a 502 Bad Gateway error when fetching the slave-agent.jnlp file through the swarm client. I have traced this down to being an issue with the way the no_proxy settings are evaluated in Jenkins remoting (swarm is currently evaluating the proxy settings correctly but remoting is not). It currently will ignore any no_proxy settings that consist of hostnames without a domain suffix, i.e. "localhost" or "jenkinsmaster".
The use case for this is that I am running a docker swarm on a corporate proxy and need to be able to exclude my Jenkins master from the proxy in order for the slaves to be able to communicate.
I believe this is a simple fix here: https://github.com/jenkinsci/remoting/blob/master/src/main/java/hudson/remoting/Util.java#L132-L140
The regex should be changed such that the '.' is optional and that the hostname/domain can have underscores '_'.
Originally reported by ajhodges, imported from: JNLP not considering plain hostnames when evaluating NO_PROXY
- status: Resolved
- priority: Minor
- component(s): remoting
- resolution: Fixed
- resolved: 2018-12-10T22:50:15+00:00
- votes: 1
- watchers: 3
- imported: 2025-11-25
Raw content of original issue
Encountering a 502 Bad Gateway error when fetching the slave-agent.jnlp file through the swarm client. I have traced this down to being an issue with the way the no_proxy settings are evaluated in Jenkins remoting (swarm is currently evaluating the proxy settings correctly but remoting is not). It currently will ignore any no_proxy settings that consist of hostnames without a domain suffix, i.e. "localhost" or "jenkinsmaster".
The use case for this is that I am running a docker swarm on a corporate proxy and need to be able to exclude my Jenkins master from the proxy in order for the slaves to be able to communicate.
I believe this is a simple fix here: https://github.com/jenkinsci/remoting/blob/master/src/main/java/hudson/remoting/Util.java#L132-L140
The regex should be changed such that the '.' is optional and that the hostname/domain can have underscores '_'.
environment
Jenkins 2.89.2<br/>
Jenkins remoting 3.1.4<br/>
Jenkins swarm 3.7
Activity
jenkins-infra-bot commentedon Jan 3, 2018
ajhodges:
Raw content of original comment:
Solution provided in
JENKINS-32326does not allow for simple hostnames in no_proxyjenkins-infra-bot commentedon Jan 9, 2018
hdevos:
Raw content of original comment:
I am encountering the same issue in same context : corporate proxy and need to connect the slave agent to my jenkins master with simple hostname (in a Docker environment)
jenkins-infra-bot commentedon Jan 9, 2018
ajhodges:
Raw content of original comment:
hdevos I'm not sure how close our setups are, but I did find a workaround. In a docker network you can append the stack/network name as a domain and it will resolve. For example .. Stack name did not work for me but network name did. Hope that helps as a workaround for this issue.
Docs: https://docs.docker.com/docker-cloud/apps/service-links/#discovering-services-or-containers-on-another-stack
jenkins-infra-bot commentedon Jan 9, 2018
hdevos:
Raw content of original comment:
ajhodges Thanks for your suggestion, i am deploying a basic docker-compose environment so unfortunately I don't have access to a stack name.
My "workaround" is to use jenkins IP instead of simple hostname but my proxy configuration is now dirty and statically resolved before my agent launch
jenkins-infra-bot commentedon Jan 9, 2018
ajhodges:
Raw content of original comment:
hdevos I just confirmed that I can ping . as well with a simple docker compose stack. The network name will be "_default" by default but you can verify by checking docker network ls
Hope that works!
jenkins-infra-bot commentedon Jan 9, 2018
hdevos:
Raw content of original comment:
I wasn't aware of this, thanks Adam! In fact I declared a dedicated network to my compose stack, therefore my container "complete" address is ._
jenkins-infra-bot commentedon Jan 9, 2018
hdevos:
Raw content of original comment:
Looks like there is another issue with this Util class:
when using docker compose network dns adress : ._ (e.g: jenkins.test_mycomposenetwork), host does not match specified regexp in https://github.com/jenkinsci/remoting/blob/master/src/main/java/hudson/remoting/Util.java#L132
jenkins-infra-bot commentedon Jan 9, 2018
ajhodges:
Raw content of original comment:
hdevos maybe try this to set a name without the directory name in there? https://docs.docker.com/compose/compose-file/compose-file-v2/#name-1
I'll add the '_' to this issue.
jenkins-infra-bot commentedon Oct 24, 2018
jthompson:
Raw content of original comment:
Here's a PR to re-work the no_proxy implementation: #293
It should deal with this report and provide additional, new capabilities.
jenkins-infra-bot commentedon Dec 10, 2018
jthompson:
Raw content of original comment:
This will be picked up by a Jenkins weekly build soon.
jenkins-infra-bot commentedon Nov 25, 2025
[Original
relates_tofrom Jira: JENKINS-32326]