[JENKINS-50965] Malformed log message #1323
Description
JENKINS-19445 added a workaround for a Windows JNA deadlock bug in pr#82. That added a log message.
Unfortunately that log message was malformed (using %s instead of {0} etc), resulting in an ugly and unhelpful log message saying:
INFO: %s class '%s' using classloader: %s
It should say something like:
INFO: Loaded class 'com.foo.Bar' using classloader: com.foo.SomeClassLoader
instead.
Originally reported by pjdarton, imported from: Malformed log message
- assignee: jthompson
- status: Resolved
- priority: Trivial
- component(s): remoting
- label(s): 2.121.2-fixed, diagnostics
- resolution: Fixed
- resolved: 2018-06-11T19:32:08+00:00
- votes: 0
- watchers: 2
- imported: 2025-11-25
Raw content of original issue
JENKINS-19445 added a workaround for a Windows JNA deadlock bug in pr#82. That added a log message. Unfortunately that log message was malformed (using %s instead of {0} etc), resulting in an ugly and unhelpful log message saying: INFO: %s class '%s' using classloader: %s
It should say something like: INFO: Loaded class 'com.foo.Bar' using classloader: com.foo.SomeClassLoader instead.
- environment:
System property hudson.remoting.RemoteClassLoader.force is set to the name of a class to be loaded, e.g. -Dhudson.remoting.RemoteClassLoader.force=com.sun.jna.Native
Activity
jenkins-infra-bot commentedon Apr 24, 2018
pjdarton:
Raw content of original comment:
See #267
jenkins-infra-bot commentedon May 9, 2018
Raw content of original comment:
Code changed in jenkins
User: Peter Darton
Path:
src/main/java/hudson/remoting/UserRequest.java
http://jenkins-ci.org/commit/remoting/3cc5305ac33a4a7e19ca053ae1dbf85163e0e2a5
Log:
JENKINS-50965- Fix log message (#267)Current code logs "INFO: %s class '%s' using classloader: %s" if system
property hudson.remoting.RemoteClassLoader.force is set.
The code should be using java.text.MessageFormat.format syntax
but is mistakenly using String.format syntax instead.
*NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
jenkins-infra-bot commentedon Jun 8, 2018
Raw content of original comment:
JENKINS-51541- Introduce new SlaveComputer#setChannel() method which takes custom ChannelBuilder and CommandTransportJENKINS-51551- Pick Remoting version with the API patchJENKINS-51541- Listener is nullable according to the documentationJENKINS-51541- Restrict SlaveComputer#setChannel(ChannelBuilder cb, …) to Beta-use only*NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
Code changed in jenkins
User: Oleg Nenashev
Path:
core/src/main/java/hudson/slaves/SlaveComputer.java
pom.xml
http://jenkins-ci.org/commit/jenkins/c405ae701c4bca18f7b4edc6e5cd3bc053b7ee60
Log:
[JENKINS-51541,JENKINS-51551,...] - Remoting 3.21 + Allow passing custom CommandTransport implementations to SlaveComputer from ComputerLauncher (#3455)
JENKINS-51541- Introduce new SlaveComputer#setChannel() method which takes custom ChannelBuilder and CommandTransportJENKINS-51551- Pick Remoting version with the API patchJENKINS-51541- Listener is nullable according to the documentationJENKINS-51541- Restrict SlaveComputer#setChannel(ChannelBuilder cb, …) to Beta-use only*NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
jenkins-infra-bot commentedon Jun 11, 2018
Raw content of original comment:
Fixed in Remoting 3.21 and Jenkins 2.127