[JENKINS-1237] JNLP error as secretKey argument is empty since build 1.175 #872

Hi,

Since version 1.175 and up to current one (1.177 at the time I'm preparing this
post), our slaves fail to launch due to a JNLP error:

BadFieldException[ The field <argument> has an invalid value : ,]

    at com.sun.javaws.jnl.XMLFormat$9.visitElement(Unknown Source)

    ...

All slaves have use a command line like:
javaws http://buildserver:8080/computer/%COMPUTERNAME%/slave-agent.jnlp

Let's have a quick look at the launch file...

<jnlp codebase="http://buildserver:8080/computer/PONTOS/" spec="1.0+">

    <information>

        <title>Slave Agent for PONTOS</title>

        <vendor>Hudson project</vendor>

        <homepage href="https://hudson.dev.java.net/"></homepage>

    </information>

    <security><all-permissions></all-permissions></security>

    <resources>

        <j2se version="1.5+"></j2se>

        <jar href="jnlpJars/jnlp-agent.jar"></jar>

        <jar href="jnlpJars/remoting.jar"></jar>

    </resources>

    <application-desc main-class="hudson.jnlp.Main">

        <argument>buildserver</argument>

        <argument>http://buildserver:8080/tcpSlaveAgentListener/</argument>

        <argument></argument>

        <argument>PONTOS</argument>

    </application-desc>

</jnlp>

... 3rd argument field (secretKey according to Engine.java) is empty.

Is it related to the recent move of the "secret.key" file management from
TcpSlaveAgentListener.java to Hudson.java?

Thank you very much,
Regis.


PS: Thanks again for the killer tool you're working on!